Re: Add LZ4 compression in pg_dump

On 5/7/23 17:01, gkokolatos(at)pm(dot)me wrote:
>
>
>
> On Sat, May 6, 2023 at 04:51, Michael Paquier <michael(at)paquier(dot)xyz
> <mailto:On Sat, May 6, 2023 at 04:51, Michael Paquier <<a href=>> wrote:
>> On Fri, May 05, 2023 at 02:13:28PM +0000, gkokolatos(at)pm(dot)me wrote:
>> > Good point. I thought about it before submitting the patch. I
>> > concluded that given the complexity and operations involved in
>> > LZ4Stream_read_internal() and the rest of t he pg_dump/pg_restore
>> > code, the memset() call will be negligible. However from the
>> > readability point of view, the function is a bit cleaner with the
>> > memset().
>> >
>> > I will not object to any suggestion though, as this is a very
>> > trivial point. Please find attached a v2 of the patch following the
>> > suggested approach.
>>
>> Please note that an open item has been added for this stuff.
> Thank you but I am not certain I know what that means. Can you please
> explain?
>

It means it was added to the list of items we need to fix before PG16
gets out:

https://wiki.postgresql.org/wiki/PostgreSQL_16_Open_Items

regards

--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company