Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: David Benjamin <davidben(at)google(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions
Date: 2024-05-19 20:21:37
Message-ID: cc9f4f2c-9839-43e3-b111-1ed572cc5180@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 19.05.24 20:07, David Benjamin wrote:
> On Sun, May 19, 2024 at 12:21 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us
> <mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us>> wrote:
>
> Per the cfbot [1], this patch needs a rebase over the ALPN-related
> commits.  It still isn't likely to get human attention before the
> July commitfest, but you can save some time by making sure it's
> in a reviewable state before that.
>
>
> Rebased version attached. (The conflict was pretty trivial. Both patches
> add a field to some struct.)

Note that there is a concurrent plan to drop support for OpenSSL older
than 1.1.1 [0], which would obsolete your configure test for
BIO_get_data. Whoever commits these should be sure to coordinate this.

[0]: https://www.postgresql.org/message-id/flat/ZG3JNursG69dz1lr(at)paquier(dot)xyz

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2024-05-19 20:32:45 Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions
Previous Message Tom Lane 2024-05-19 19:18:11 Re: commitfest.postgresql.org is no longer fit for purpose