Re: BUG #17083: [PATCH] PostgreSQL fails to build with OpenLDAP 2.5.x

On 6/7/21 9:46 pm, Tom Lane wrote:
> PG Bug reporting form <noreply(at)postgresql(dot)org> writes:
>> OpenLDAP 2.5 merged the `ldap_r` and `ldap` libraries, so all per-handle
>> routines are now thread-safe by default.
>
> Hm, does 2.5 exist in the wild yet? I checked Fedora rawhide, which
> is my usual go-to platform for bleeding-edge stuff, but they are still
> at 2.4.58.

Gentoo and some other distros have pushed 2.5.5 out:
https://repology.org/project/openldap/badges. This patch actually grew
out of fixing the Homebrew Linux PostgreSQL build:
https://github.com/Homebrew/homebrew-core/pull/80643

> As for the patch itself, I'm wondering about
>
> + LDAP_LIBS_FE="${ac_lib:+-l}$ac_lib $EXTRA_LDAP_LIBS"
>
> That seems undesirably intimate with the implementation details
> of AC_SEARCH_LIBS. Surely there's a better way?

Hmmm, good point, my Autotools-fu is not very strong. I'll see if
there's a blessed way of doing the above, otherwise I'll probably have
to test each library separately in an AC_CHECK_LIB cascade instead.

--
Best Regards,
Adrian