| From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: GISTSTATE is too large |
| Date: | 2021-05-30 13:14:33 |
| Message-ID: | cc5e30ca-c479-2eac-3c78-5b453469a150@proxel.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4/26/21 12:20 AM, Andres Freund wrote:
> It seems pretty clear that this should be changed to be something more
> like
>
> [...]
>
> with initGISTstate allocating based on
> IndexRelationGetNumberOfKeyAttributes() instead of using a constant.
>
> And then subsequently change GIST_COL_STATE to embed the
> FunctionCallInfo, rather than initializiing them on the stack for every
> call.
>
>
> I'm not planning on doing this work, but I thought it's sensible to send
> to the list anyway.
I did the first part since it seemed easy enough and an obvious win for
all workloads.
Andreas
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Shrink-GISTSTATE.patch | text/x-patch | 14.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhihong Yu | 2021-05-30 14:21:28 | Re: GISTSTATE is too large |
| Previous Message | Asif Rehman | 2021-05-30 12:38:36 | Re: [PATCH] expand the units that pg_size_pretty supports on output |