Re: POC, WIP: OR-clause support for indexes

From: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: "Lena(dot)ribackina(at)yandex(dot)ru" <Lena(dot)ribackina(at)yandex(dot)ru>, Marcos Pegoraro <marcos(at)f10(dot)com(dot)br>
Subject: Re: POC, WIP: OR-clause support for indexes
Date: 2023-06-28 21:45:36
Message-ID: cc145d1a-a245-3a14-c9d6-c6300b2872a3@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 6/27/23 20:55, Ranier Vilela wrote:
> Hi,
>
>>I finished writing the code patch for transformation "Or" expressions to
>>"Any" expressions. I didn't see any problems in regression tests, even
>>when I changed the constant at which the minimum or expression is
>>replaced by any at 0. I ran my patch on sqlancer and so far the code has
>>never fallen.
> Thanks for working on this.
>
> I took the liberty of making some modifications to the patch.
> I didn't compile or test it.
> Please feel free to use them.
>

I don't want to be rude, but this doesn't seem very helpful.

- You made some changes, but you don't even attempt to explain what you
changed or why you changed it.

- You haven't even tried to compile the code, nor tested it. If it
happens to compile, wow could others even know it actually behaves the
way you wanted?

- You responded in a way that breaks the original thread, so it's not
clear which message you're responding to.

regards

--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2023-06-28 21:53:32 Re: Problems with estimating OR conditions, IS NULL on LEFT JOINs
Previous Message Tomas Vondra 2023-06-28 21:30:11 Re: several attstattarget-related improvements