Re: Cutting support for OpenSSL 1.0.1 and 1.0.2 in 17~?

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>, Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, mikael(dot)kjellstrom(at)gmail(dot)com
Subject: Re: Cutting support for OpenSSL 1.0.1 and 1.0.2 in 17~?
Date: 2024-04-05 21:26:00
Message-ID: cb9b778f-5573-45dc-9d60-0573020b8b9c@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 05.04.24 18:59, Daniel Gustafsson wrote:
> Attached is a WIP patch to get more eyes on it, the Meson test for 1.1.1 fails
> on Windows in CI which I will investigate next.

I'm not a fan of the new PGAC_CHECK_OPENSSL. It creates a second place
where the OpenSSL version number has to be updated. We had this
carefully constructed so that there is only one place that
OPENSSL_API_COMPAT is defined and that is the only place that needs to
be updated. We put the setting of OPENSSL_API_COMPAT into configure so
that the subsequent OpenSSL tests would use it, and if the API number
higher than what the library supports, the tests should fail. So I
don't understand why the configure changes have to be so expansive.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2024-04-05 21:48:30 Re: Cutting support for OpenSSL 1.0.1 and 1.0.2 in 17~?
Previous Message Tom Lane 2024-04-05 21:18:51 Re: IPC::Run::time[r|out] vs our TAP tests