Re: SQL/JSON path issues/questions

From: Liudmila Mantrova <l(dot)mantrova(at)postgrespro(dot)ru>
To: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Thom Brown <thom(at)linux(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: SQL/JSON path issues/questions
Date: 2019-07-04 13:38:14
Message-ID: cb88310b-ec07-2947-957a-8411e8f15534@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 7/3/19 11:59 PM, Alexander Korotkov wrote:
> Hi!
>
> On Wed, Jul 3, 2019 at 5:27 PM Liudmila Mantrova
> <l(dot)mantrova(at)postgrespro(dot)ru> wrote:
>> I have rechecked the standard and I agree that we should use "filter
>> expression" whenever possible.
>> "A filter expression must be enclosed in parentheses..." looks like an
>> oversight, so I fixed it. As for what's actually enclosed, I believe we
>> can still use the word "condition" here as it's easy to understand and
>> is already used in our docs, e.g. in description of the WHERE clause
>> that serves a similar purpose.
>> The new version of the patch fixes the terminology, tweaks the examples,
>> and provides some grammar and style fixes in the jsonpath-related chapters.
>
> It looks good to me. But this sentence looks a bit too complicated.
>
> "It can be followed by one or more accessor operators to define the
> JSON element on a lower nesting level by which to filter the result."
>
> Could we phrase this as following?
>
> "In order to filter the result by values lying on lower nesting level,
> @ operator can be followed by one or more accessor operators."
>
> ------
> Alexander Korotkov
> Postgres Professional: http://www.postgrespro.com
> The Russian Postgres Company

Thank  you!

I think we can make this sentence even shorter, the fix is attached:

"To refer to a JSON element stored at a lower nesting level, add one or
more accessor operators after <literal>@</literal>."

--
Liudmila Mantrova
Technical writer at Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
0004-clarify-jsonpath-docs-4.patch text/x-patch 9.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Cramer 2019-07-04 13:49:30 Re: Binary support for pgoutput plugin
Previous Message Kumar, Pawan (Nokia - IN/Bangalore) 2019-07-04 13:37:01 duplicate key entries for primary key -- need urgent help