Re: Fixes for pgAdmin4 messages

From: Alexander Lakhin <exclusion(at)gmail(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Fixes for pgAdmin4 messages
Date: 2017-11-01 09:12:48
Message-ID: cb849765-ceac-b90c-a774-bf72f7ab5c7e@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

01.11.2017 12:04, Dave Page wrote:
> Hi,
>
> Can you re-sent this as a single patch please? Working through 23 will
> take me significantly more time (which I have little of).
Sure, If you are going to accept all (or almost all) the changes, a
single patch is better.
>
> On Wed, Nov 1, 2017 at 7:33 AM, Alexander Lakhin <exclusion(at)gmail(dot)com
> <mailto:exclusion(at)gmail(dot)com>> wrote:
>
> Hello,
>
> While translating the messages, I encountered some English
> messages, that I think should be fixed.
> Please consider applying the attached patches.
> If you have any concerns or questions, I'm ready to explain all
> the fixes proposed.
>
> And I have a question - do you use some kind of style guide?
> (Something like:
> https://www.postgresql.org/docs/10/static/error-style-guide.html
> <https://www.postgresql.org/docs/10/static/error-style-guide.html>)
> In particular, I'm confused with such messages:
> This URL cannot be called directly!
> This URL cannot be called directly.
> ...
> Name must be specified.
> Name must be specified!
> ...
> Are there any reasons to use exclamation marks in some of the
> messages? And if so, in which messages exactly they should be used?
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

Best regards,
------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
all-fixes.patch text/x-patch 22.8 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2017-11-01 11:58:22 [pgAdmin4][Patch]: To handle long numbers for Rows (estimated) field in Table's properties
Previous Message Dave Page 2017-11-01 09:04:43 Re: Fixes for pgAdmin4 messages