| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Tighten pg_get_object_address argument checking |
| Date: | 2022-09-21 14:00:20 |
| Message-ID: | cae11966-002e-982f-0cbe-65a8f2679699@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 21.09.22 12:01, Amit Kapila wrote:
> On Tue, Sep 20, 2022 at 11:14 PM Peter Eisentraut
> <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>>
>> For publication schemas (OBJECT_PUBLICATION_NAMESPACE) and user
>> mappings (OBJECT_USER_MAPPING), pg_get_object_address() checked the
>> array length of the second argument, but not of the first argument.
>> If the first argument was too long, it would just silently ignore
>> everything but the first argument. Fix that by checking the length of
>> the first argument as well.
>
> LGTM.
Committed, thanks for checking.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-09-21 14:04:45 | Re: Mingw task for Cirrus CI |
| Previous Message | Ashutosh Bapat | 2022-09-21 13:51:02 | Re: confirmed_flush_lsn shows LSN of the data that has not yet been received by the logical subscriber. |