Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm
Date: 2021-07-13 15:01:53
Message-ID: ca06751a-deb1-6f07-b1ac-7c4df17e392d@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 13.07.21 09:53, Michael Paquier wrote:
> I was thinking to just do the easiest move and fix this issue down to
> 13, not bothering about older branches :p
>
> Looking at the commit, a backpatch is not that complicated and it is
> possible to check the generation of pg_config.h on non-MSVC
> environments if some objects are missing. Still, I think that it
> would be better to be careful and test this code properly on Windows
> with a real build. It means that.. Err... Andrew or I should look
> at that. I am not sure that the potential maintenance gain is worth
> poking at the stable branches, to be honest.

We have lived with the previous system for a decade, so I think
backpatching this would be a bit excessive.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2021-07-13 15:33:22 Re: Printing backtrace of postgres processes
Previous Message Simon Riggs 2021-07-13 14:59:47 Re: Detecting File Damage & Inconsistencies