| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] replace GrantObjectType with ObjectType |
| Date: | 2017-12-15 17:40:49 |
| Message-ID: | c9ffa5d4-889e-e1c5-fb55-a9f53f17b0e0@2ndquadrant.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/14/17 22:59, Rushabh Lathia wrote:
> I noted that no_priv_msg and not_owner_msg array been removed
> and code fitted the code into aclcheck_error(). Actually that
> makes the code more complex then what it used to be. I would
> prefer the array rather then code been fitted into the function.
There is an argument for having a big array versus the switch/case
approach. But most existing code around object addresses uses the
switch/case approach, so it's better to align it that way, I think.
It's weird to have to maintain two different styles.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Geoff Winkless | 2017-12-15 17:57:58 | Re: [PROPOSAL] bracketed-paste support for psql |
| Previous Message | Peter Eisentraut | 2017-12-15 17:39:16 | Re: [HACKERS] replace GrantObjectType with ObjectType |