Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion

2021-10-15 13:29 に Shinya Kato さんは書きました:
> On 2021-10-14 14:30, katouknl wrote:
>>> It is very good, but it seems to me that there are some
>>> tab-completion
>>> missing in COMMENT command.
>>> For example,
>>> - CONSTRAINT ... ON DOMAIN
>>> - OPERATOR CLASS
>>> - OPERATOR FAMILY
>>> - POLICY ... ON
>>> - [PROCEDURAL]
>>> - RULE ... ON
>>> - TRIGGER ... ON
>>>
>>> I think these tab-comletion also can be improved and it's a good
>>> timing for that.
>>
>> Thank you for the comments!
>>
>> I fixed where you pointed out.
> Thank you for the update!
> I tried "COMMENT ON OPERATOR ...", and an operator seemed to be
> complemented with double quotation marks.
> However, it caused the COMMENT command to fail.
> ---
> postgres=# COMMENT ON OPERATOR "+" (integer, integer) IS 'test_fail';
> ERROR: syntax error at or near "("
> LINE 1: COMMENT ON OPERATOR "+" (integer, integer) IS 'test_fail';
> postgres=# COMMENT ON OPERATOR + (integer, integer) IS 'test_success';
> COMMENT
> ---
>
> So, I think as with \do command, you do not need to complete the
> operators.
> Do you think?
Thank you for the further comments!

I fixed so that it doesn't complete the operators anymore.
It only completes with CLASS and FAMILY.

Also, I updated TEXT SEARCH.
It completes object names for each one of CONFIGURATION, DICTIONARY,
PARSER, and TEMPLATE.

--
Best wishes,

Ken Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION