| From: | Tomas Vondra <tomas(at)vondra(dot)me> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix for pageinspect bug in PG 17 |
| Date: | 2024-12-17 17:01:39 |
| Message-ID: | c8efce94-d426-4aa4-b880-b94921ed74e4@vondra.me |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I've pushed (and backpatched) a fix for this.
I ended up doing the simplest thing -- error out if the number of
columns does not match, suggesting to update to latest extension version.
I considered handling it in a nicer way, but I didn't like the result
very much and I think that's sufficient for superuser-only extension.
And 691e8b2e18 seems like a reasonable precedent (even though the
backbranches did do a different thing).
I also considered introducing pg_stat_statements-style versioning, but
it's too late to do that in backbranches, and I don't think we expect
the function to change very often to justify this.
regards
--
Tomas Vondra
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2024-12-17 17:06:28 | Re: Maybe we should reduce SKIP_PAGES_THRESHOLD a bit? |
| Previous Message | Melanie Plageman | 2024-12-17 16:44:44 | Re: Maybe we should reduce SKIP_PAGES_THRESHOLD a bit? |