Re: pgsql: Replace PostmasterRandom() with a stronger source, second attemp

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Replace PostmasterRandom() with a stronger source, second attemp
Date: 2016-12-07 07:49:03
Message-ID: c8aeac67-d964-5559-8ead-f08f41df0467@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 12/07/2016 02:30 AM, Michael Paquier wrote:
> With the logs complaining as well:
> [1-1] db=[unknown],user=[unknown],app=[unknown],client=[local] LOG:
> wrong key in cancel request for process 57361
>
> As far as I can see processCancelRequest uses a long variable, and it
> gets compared with an int32. MyCancelKey has been changed to an int32
> in globals.c with the above commit. So on 64b machines the current
> code is aimed to fail. Attached is a patch to fix the issue.

Pushed, thanks!

- Heikki

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-12-07 17:20:17 pgsql: Handle empty or all-blank PAGER setting more sanely in psql.
Previous Message Heikki Linnakangas 2016-12-07 07:48:21 pgsql: Fix query cancellation.