| From: | Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, David Zhang <david(dot)zhang(at)highgo(dot)ca>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, rmt(at)lists(dot)postgresql(dot)org, horikyota(dot)ntt(at)gmail(dot)com |
| Subject: | Re: psql: Add role's membership options to the \du+ command |
| Date: | 2023-07-12 10:21:42 |
| Message-ID: | c881e88b-ab02-775b-9d12-95787d603175@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 09.07.2023 13:56, Pavel Luzanov wrote:
> On 08.07.2023 20:07, Tom Lane wrote:
>> 1. I was thinking in terms of dropping the "Member of" column entirely
>> in \du and \dg. It doesn't tell you enough, and the output of those
>> commands is often too wide already.
>
>> 2. You have describeRoleGrants() set up to localize "ADMIN", "INHERIT",
>> and "SET". Since those are SQL keywords, our usual practice is to not
>> localize them; this'd simplify the code.
>
>
>> 3. Not sure about use of LEFT JOIN in the query. That will mean we
>> get a row out even for roles that have no grants, which seems like
>> clutter. The LEFT JOINs to r and g are fine, but I suggest changing
>> the first join to a plain join.
>
> So, I accepted all three suggestions. I will wait for other opinions and
> plan to implement discussed changes within a few days.
Please review the updated version with suggested changes.
--
Pavel Luzanov
Postgres Professional: https://postgrespro.com
| Attachment | Content-Type | Size |
|---|---|---|
| v9-0001-psql-add-drg-command-to-show-role-memberships-and.patch | text/x-patch | 14.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2023-07-12 11:34:56 | Re: Consistent coding for the naming of LR workers |
| Previous Message | Amit Kapila | 2023-07-12 10:08:43 | Re: doc: improve the restriction description of using indexes on REPLICA IDENTITY FULL table. |