Re: TAP test for recovery_end_command

From: "Euler Taveira" <euler(at)eulerto(dot)com>
To: "Amul Sul" <sulamul(at)gmail(dot)com>, "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: TAP test for recovery_end_command
Date: 2021-09-13 00:25:32
Message-ID: c8631944-02bd-4157-be64-97da474bdcb3@www.fastmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 9, 2021, at 8:18 AM, Amul Sul wrote:
> The attached patch adds a small test for recovery_end_command execution.
Additional coverage is always a good thing.

> Currently, patch tests execution of recovery_end_command by creating
> dummy file, I am not wedded only to this approach, other suggestions
> also welcome.
This test file is for archiving only. It seems 020_archive_status.pl is more
appropriate for testing this parameter.

> Also, we don't have a good test for archive_cleanup_command as well, I
> am not sure how we could test that which executes with every
> restart-point.
Setup a replica and stop it. It triggers a restartpoint during the shutdown.

--
Euler Taveira
EDB https://www.enterprisedb.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jaime Casanova 2021-09-13 00:44:47 brin multi minmax crash for inet value
Previous Message Bossart, Nathan 2021-09-12 23:02:49 Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c