| From: | Adrien Nayrat <adrien(dot)nayrat(at)anayrat(dot)info> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, <vik(dot)fearing(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Michael Paquier" <michael(at)paquier(dot)xyz>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: New GUC to sample log queries |
| Date: | 2018-11-29 21:09:10 |
| Message-ID: | c80bad2d-c865-5bf2-71b9-fa95127d34f9@anayrat.info |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/29/18 6:35 PM, Alvaro Herrera wrote:
>
> Sounds good to me (we -> you, I suppose?). I'd tweak the extra_desc for
> log_min_duration_statement too, because we no longer log "all" when the
> rate is <1; maybe "Zero prints all queries, subject to
> log_statement_sample_rate. -1 turns this feature off."
Right, I also changed a part of log_min_duration_statement documentation to
mention log_statement_sample_rate
>
> I just noticed we don't use "you" anywhere in the descs, except for this
> one:
Maybe we could change with something like this :
long_desc: "Take a value between 0 (never log) and 1.0 (always log) to log a
sample."
Thanks,
| Attachment | Content-Type | Size |
|---|---|---|
| sample_rate-7.patch | text/x-patch | 6.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-11-29 21:23:42 | Re: pg_config wrongly marked as not parallel safe? |
| Previous Message | Stephen Frost | 2018-11-29 21:01:36 | Re: pg_config wrongly marked as not parallel safe? |