| From: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
|---|---|
| To: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Steele <david(at)pgmasters(dot)net>, peter(dot)eisentraut(at)2ndquadrant(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Generic type subscripting |
| Date: | 2017-03-28 09:58:33 |
| Message-ID: | c7cc0592-4c9b-699d-3b61-810804759de6@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello,
On 27.03.2017 23:28, Dmitry Dolgov wrote:
> Here is a new version of this patch. What was changed:
>
> * I rebased code against the latest version of master and adapted recent
> changes about the expression execution
>
> * Several names (functions and related pg_type column) were changed
>
> * A new oid function field was introduced to handle nested assignment
> situation
>
> * I updated the documentation for patch
>
> * `MAXDIM` was replaced by `MAX_SUBSCRIPT_DEPTH`
>
> * I returned one `SubscriptingRef` for both fetch & assign operations, since
> there is no real readability improvements at this point (they're already
> separated at the time of evaluation, and besides the evaluation code
> fetch &
> assign are handled almost identically).
Your patch reverts commits from 25-26 march. And therefore contains
15000 lines.
I think the patch needs rebasing.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2017-03-28 10:08:07 | Re: [PATCH] Generic type subscripting |
| Previous Message | David Rowley | 2017-03-28 09:30:03 | extended stats not friendly towards ANALYZE with subset of columns |