| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Josh Berkus <josh(at)agliodbs(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Proposal for changes to recovery.conf API |
| Date: | 2017-01-11 19:52:56 |
| Message-ID: | c6965ef8-f200-23d8-d2ed-36b333d25640@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/11/17 12:53 PM, Simon Riggs wrote:
>> I'm concerned that having signal files somewhere else opens up a bunch
>> more edge cases that need to be considered. For example, what if
>> someone puts a signal file into a temporary directory that is cleared
>> after a server crash and restart. That can mess up a bunch of things.
>
> We already have trigger_file as a way to specify an alternate
> directory, so if I remove signal_file_directory I will need to replace
> trigger_file as a parameter.
The trigger file is for promotion, which is just a momentary nudge to
the server. The recovery signal file or whatever we end up calling it
is long-term state, because if it disappears and the server restarts, it
will do something different. So they are different.
I'm not strictly opposed to making the name or directory configurable,
but I'm predicting it will raise more questions than we might want to
deal with.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Merlin Moncure | 2017-01-11 19:53:07 | Re: merging some features from plpgsql2 project |
| Previous Message | Bruce Momjian | 2017-01-11 19:42:00 | Re: Packages: Again |