| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Adding OLD/NEW support to RETURNING |
| Date: | 2024-03-27 07:47:10 |
| Message-ID: | c68183f1094d4dd61e4535da511cd7454954f5d5.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 2024-03-26 at 18:49 +0000, Dean Rasheed wrote:
> On Mon, 25 Mar 2024 at 14:04, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
> wrote:
> >
> > v7 patch attached, with those updates.
> >
>
> Rebased version attached, forced by 87985cc925.
This isn't a complete review, but I spent a while looking at this, and
it looks like it's in good shape.
I like the syntax, and I think the solution for renaming the alias
("RETURNING WITH (new as n, old as o)") is a good one.
The implementation touches quite a few areas. How did you identify all
of the potential problem areas? It seems the primary sources of
complexity came from rules, partitioning, and updatable views, is that
right?
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2024-03-27 08:12:19 | Re: New Table Access Methods for Multi and Single Inserts |
| Previous Message | Shubham Khanna | 2024-03-27 07:44:44 | Re: Improve eviction algorithm in ReorderBuffer |