Re: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR

From: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR
Date: 2022-02-09 15:27:39
Message-ID: c6738ae0-04ce-3e4d-64f7-48dab8c22145@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2/9/22 06:41, Noah Misch wrote:
>
> The explanation was more boring than that. v13 and earlier have an additional
> InvalidateSystemCaches() call site, which I neglected to update. Here's the
> fix I intend to push.

I tried this patch on 10 and 13, and it seems to fix the issue. So +1.

regards

--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-02-09 19:25:08 pgsql: Test honestly for <sys/signalfd.h>.
Previous Message Daniel Gustafsson 2022-02-09 15:15:31 pgsql: Fix typo in archive modules docs

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2022-02-09 15:45:02 Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)
Previous Message Ashutosh Sharma 2022-02-09 15:06:31 Re: Identify missing publications from publisher while create/alter subscription.