Re: what should install-world do when docs are not available?

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org, Justin Pryzby <pryzby(at)telsasoft(dot)com>
Subject: Re: what should install-world do when docs are not available?
Date: 2023-03-29 16:39:27
Message-ID: c61657b2-2892-5be3-5e9a-55cc5b8c2a95@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 29.03.23 18:25, Andres Freund wrote:
> On 2023-03-29 18:15:02 +0200, Peter Eisentraut wrote:
>> On 25.03.23 21:14, Andres Freund wrote:
>>> I wonder if, for meson, the best behaviour would be to make 'docs' a feature
>>> set to auto. If docs set to enabled, and the necessary tools are not
>>> available, fail at that time, instead of doing so while building.
>>
>> Makes sense to me.
>>
>>> If that's what we decide to do, perhaps "docs" should be split further? The
>>> dependencies for pdf generation are a lot more heavyweight.
>>
>> I think "docs" should be html and man, because that's what gets installed.
>>
>> pdf and other things can just be an ad hoc build target and doesn't need
>> install support.
>
> I just meant for feature detection.

Ah yes, then things like fop should either be a separate feature or just
do something light weight, like failing the target if fop isn't there.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zheng Li 2023-03-29 16:53:31 Re: Support logical replication of DDLs
Previous Message Andres Freund 2023-03-29 16:25:03 Re: what should install-world do when docs are not available?