| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, smilingsamay(at)gmail(dot)com, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Lukas Fittl <lukas(at)fittl(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: Add shared buffer hits to pg_stat_io |
| Date: | 2023-03-09 16:03:13 |
| Message-ID: | c5e746a9-7702-42bf-41da-43280f48b1d1@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 3/9/23 2:23 PM, Melanie Plageman wrote:
> On Wed, Mar 8, 2023 at 2:23 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>>
>> On 2023-03-08 13:44:32 -0500, Melanie Plageman wrote:
>>> However, I am concerned that, while unlikely, this could be flakey.
>>> Something could happen to force all of those blocks out of shared
>>> buffers (even though they were just read in) before we hit them.
>>
>> You could make the test query a simple nested loop self-join, that'll prevent
>> the page being evicted, because it'll still be pinned on the outer side, while
>> generating hits on the inner side.
>
> Good idea. v3 attached.
Thanks! The added test looks good to me.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-03-09 16:10:32 | Re: Disable rdns for Kerberos tests |
| Previous Message | Himanshu Upadhyaya | 2023-03-09 15:54:38 | Re: HOT chain validation in verify_heapam() |