From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | TAP tests and symlinks on Windows |
Date: | 2020-06-08 12:44:31 |
Message-ID: | c50a646c-d9bb-7c62-a4bf-8256ff6ff338@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
The tests
src/bin/pg_basebackup/t/010_pg_basebackup.pl
src/bin/pg_rewind/t/004_pg_xlog_symlink.pl
both contain a TAP skip notice "symlinks not supported on Windows".
This is untrue. Symlinks certainly work on Windows, and we have other
TAP tests using them, for example for tablespaces.
pg_rewind/t/004_pg_xlog_symlink.pl passes for me on Windows if I just
remove the skip stuff. My attached patch does that.
If I remove the skip stuff in pg_basebackup/t/010_pg_basebackup.pl, it
fails in various interesting ways. Apparently, some more work is needed
to get the various paths handled correct on Windows. (At least a
TestLib::perl2host call appears to be required.) I don't have the
enthusiasm to fix this right now, but my patch at least updates the
comment from "this isn't supported" to "this doesn't work correctly yet".
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment | Content-Type | Size |
---|---|---|
0001-Enable-some-symlink-tests-on-Windows.patch | text/plain | 1.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Ashutosh Bapat | 2020-06-08 13:11:36 | Re: Wrong width of UNION statement |
Previous Message | Masahiro Ikeda | 2020-06-08 11:45:15 | Re: Is it useful to record whether plans are generic or custom? |