Re: TAP tests and symlinks on Windows

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: TAP tests and symlinks on Windows
Date: 2020-06-09 07:19:31
Message-ID: 20200609071931.GE38342@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 08, 2020 at 02:44:31PM +0200, Peter Eisentraut wrote:
> both contain a TAP skip notice "symlinks not supported on Windows".
>
> This is untrue. Symlinks certainly work on Windows, and we have other TAP
> tests using them, for example for tablespaces.

> pg_rewind/t/004_pg_xlog_symlink.pl passes for me on Windows if I just remove
> the skip stuff. My attached patch does that.

What's the version of your perl installation on Windows? With 5.22, I
am still seeing that symlink() is not implemented, causing the tests
of pg_rewind to blow in flight with your patch (MSVC 2015 here).
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Gierth 2020-06-09 07:24:26 Re: Speedup usages of pg_*toa() functions
Previous Message Masahiko Sawada 2020-06-09 07:11:57 Re: Resetting spilled txn statistics in pg_stat_replication