| From: | Jim Nasby <jim(dot)nasby(at)openscg(dot)com> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net> |
| Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)2ndquadrant(dot)com> |
| Subject: | Re: PinBuffer() no longer makes use of strategy |
| Date: | 2017-03-19 00:51:42 |
| Message-ID: | c42b6f06-0cc6-d28e-b5d2-1c8d1d48f1c7@openscg.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/16/17 12:48 PM, David Steele wrote:
> This patch looks pretty straight forward and applies cleanly and
> compiles at cccbdde.
>
> It's not a straight revert, though, so still seems to need review.
>
> Jim, do you know when you'll have a chance to look at that?
Yes. Compiles and passes for me as well.
One minor point: previously the code did
if (buf->usage_count < BM_MAX_USAGE_COUNT)
but now it does
if (BUF_STATE_GET_USAGECOUNT(buf_state) != BM_MAX_USAGE_COUNT)
being prone to paranoia, I prefer the first, but I've seen both styles
in the code so I don't know if it's worth futzing with.
Marked as RFC.
--
Jim Nasby, Chief Data Architect, Austin TX
OpenSCG http://OpenSCG.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-03-19 03:50:40 | Re: [HACKERS] Questionable tag usage |
| Previous Message | Jim Nasby | 2017-03-19 00:29:34 | Re: Improve OR conditions on joined columns (common star schema problem) |