Re: BUG #18855: Using BRIN index with int8_bloom_ops produces incorrect results

From: Tomas Vondra <tomas(at)vondra(dot)me>
To: arseniy(dot)mukhin(dot)dev(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org, PG Bug reporting form <noreply(at)postgresql(dot)org>
Subject: Re: BUG #18855: Using BRIN index with int8_bloom_ops produces incorrect results
Date: 2025-03-19 17:11:07
Message-ID: c403a0a0-13b9-4e88-b95b-ba533e0a6988@vondra.me
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 3/19/25 14:43, Tomas Vondra wrote:
>
> ...
>
> I'll get this fixed shortly. Unfortunately, this means the "bloom"
> filters may be broken - not just those built in parallel, the union
> method can be triggered due to concurrent activity too.
>

Here's a more complete version of the fix, along with a proper commit
message, etc.

While working on this, I realized there's a second (less severe issue,
in that it fails to free the decompressed filters. I believe this would
be mostly harmless before parallel builds, because we'd merge only one
summary at a time, I think. With parallel builds it may be much worse,
but I'm yet to try how bad.

FWIW I think the minmax-multi has a similar memory leak.

regards

--
Tomas Vondra

Attachment Content-Type Size
0001-Keep-decompressed-filter-in-brin_bloom_union.patch text/x-patch 2.2 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tomas Vondra 2025-03-19 19:53:50 Re: BUG #18855: Using BRIN index with int8_bloom_ops produces incorrect results
Previous Message Tom Lane 2025-03-19 15:45:20 Re: Possible bug acldefault function