| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | "Shinoda, Noriyoshi (PN Japan GCS Delivery)" <noriyoshi(dot)shinoda(at)hpe(dot)com>, "fabriziomello(at)gmail(dot)com" <fabriziomello(at)gmail(dot)com>, "[pgdg] Robert Haas" <robertmhaas(at)gmail(dot)com>, "michael(at)paquier(dot)xyz" <michael(at)paquier(dot)xyz> |
| Cc: | Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module |
| Date: | 2018-09-05 16:46:51 |
| Message-ID: | c4025c2e-640b-dc21-f9cd-50c5b9dea64f@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01/09/2018 06:33, Shinoda, Noriyoshi (PN Japan GCS Delivery) wrote:
> Certainly the PQconndefaults function specifies Debug flag for the "options" option.
> I think that eliminating the Debug flag is the simplest solution.
> For attached patches, GUC can be specified with the following syntax.
>
> CREATE SERVER remsvr1 FOREIGN DATA WRAPPER postgres_fdw OPTIONS (host 'host 1', ..., options '-c work_mem=64MB -c geqo=off');
> ALTER SERVER remsv11 OPTIONS (SET options '-c work_mem=64MB -c geqo=off');
>
> However, I am afraid of the effect that this patch will change the behavior of official API PQconndefaults.
It doesn't change the behavior of the API, it just changes the result of
the API function, which is legitimate and the reason we have the API
function in the first place.
I think this patch is fine. I'll work on committing it.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chris Travers | 2018-09-05 16:48:44 | Re: Funny hang on PostgreSQL 10 during parallel index scan on slave |
| Previous Message | Andres Freund | 2018-09-05 16:42:06 | Re: Bug fix for glibc broke freebsd build in REL_11_STABLE |