| From: | ikedarintarof <ikedarintarof(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: doc: modify the comment in function libpqrcv_check_conninfo() |
| Date: | 2024-06-27 10:27:33 |
| Message-ID: | c380192faada009af9aa5bfcd06e140d@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for your suggestion. I used ChatGPT to choose the wording, but
it's still difficult for me.
The new patch includes your suggestion.
On 2024-06-27 17:18, Jelte Fennema-Nio wrote:
> On Thu, 27 Jun 2024 at 09:09, ikedarintarof
> <ikedarintarof(at)oss(dot)nttdata(dot)com> wrote:
>>
>> Thank you for your comment!
>>
>> I've added the must_use_password argument. A new patch is attached.
>
> s/whther/whether
>
> nit: "it will do nothing" sounds a bit strange to me (but I'm not
> native english). Something like this reads more natural to me:
>
> an error. If must_use_password is true, the function raises an error
> if no password is provided in the connection string. In any other case
> it successfully completes.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-modify-the-commnet-in-libpqrcv_check_conninfo.patch | text/x-diff | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2024-06-27 10:33:30 | Re: Conflict Detection and Resolution |
| Previous Message | Amit Langote | 2024-06-27 09:57:09 | Re: pgsql: Add more SQL/JSON constructor functions |