Re: Remove useless casts to (char *)

On 06.02.25 12:49, Dagfinn Ilmari Mannsåker wrote:
> I have only skimmed the patches, but one hunk jumped out at me:
>
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>
>> diff --git a/src/backend/libpq/pqcomm.c b/src/backend/libpq/pqcomm.c
>> index 1bf27d93cfa..937a2b02a4f 100644
>> --- a/src/backend/libpq/pqcomm.c
>> +++ b/src/backend/libpq/pqcomm.c
>> @@ -1368,7 +1368,7 @@ internal_flush_buffer(const char *buf, size_t *start, size_t *end)
>> {
>> int r;
>>
>> - r = secure_write(MyProcPort, (char *) bufptr, bufend - bufptr);
>> + r = secure_write(MyProcPort, unconstify(char *, bufptr), bufend - bufptr);
>>
>> if (r <= 0)
>> {
>
> Insted of unconstify here, could we not make secure_write() (and
> be_tls_write()) take the buffer pointer as const void *, like the
> attached?

Yeah, that makes sense. I've committed that. Here is a new patch set
rebased over that.