Re: recovery_target_action=pause with confusing hint

On 2020/03/31 18:59, Sergei Kornilov wrote:
> Hello
>
>> When I test the patch, I find an issue: I start a stream with 'promote_trigger_file'
>> GUC valid, and exec pg_wal_replay_pause() during recovery and as below it
>> shows success to pause at the first time. I think it use a initialize
>> 'SharedPromoteIsTriggered' value first time I exec the pg_wal_replay_pause().
>
> hm. Are you sure this is related to this patch? Could you explain the exact timing? I mean log_statement = all and relevant logs.
> Most likely this is expected change by https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=496ee647ecd2917369ffcf1eaa0b2cdca07c8730

Yeah, if the problem exists there, that would be my fault in the commit.
movead li, could you share the detail procedure to reproduce the issue?
I'm happy to investigate it.

> My proposal does not change the behavior after this commit, only changing the lines in the logs.

Yes. What's your opinion about the latest patch based on Robert's idea?
Barring any ojection, I'd like to commit that.

Regards,

--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters