Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal

From: Josh Berkus <josh(at)berkus(dot)org>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Daniel Verite <daniel(at)manitou-mail(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Vladimir Rusinov <vrusinov(at)google(dot)com>, David Steele <david(at)pgmasters(dot)net>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Cynthia Shang <cynthia(dot)shang(at)crunchydata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal
Date: 2017-02-09 20:49:37
Message-ID: c18030f8-0601-bde3-62a4-d1da707ba068@berkus.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 02/09/2017 12:42 PM, Stephen Frost wrote:
> * Josh Berkus (josh(at)berkus(dot)org) wrote:
>> On 02/09/2017 11:08 AM, Tom Lane wrote:
>>> Agreed, let's just get it done.
>>>
>>> Although this doesn't really settle whether we ought to do 3a (with
>>> backwards-compatibility function aliases in core) or 3b (without 'em).
>>> Do people want to re-vote, understanding that those are the remaining
>>> choices?
>>
>> Does 3a) mean keeping the aliases more-or-less forever?
>>
>> If not, I vote for 3b. If we're going to need to break stuff, let's
>> just do it.
>>
>> If we can keep the aliases for 6-10 years, then I see no reason not to
>> have them (3a). They're not exactly likely to conflict with user-chosen
>> names.
>
> When we remove pg_shadow, then I'll be willing to agree that maybe we
> can start having things in PG for a couple releases that are just for
> backwards-compatibility and will actually be removed later.
>
> History has shown that's next to impossible, however.

That's why I said 6-10 years. If we're doing 3a, realistically we're
supporting it until PostgreSQL 16, at least, and more likely 20. I'm OK
with that.

What I'm voting against is the idea that we'll have aliases in core, but
remove them in two releases. Either that's unrealistic, or it's just
prolonging the pain.

--
Josh Berkus
Containers & Databases Oh My!

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-02-09 20:51:11 Re: Parallel tuplesort (for parallel B-Tree index creation)
Previous Message Stephen Frost 2017-02-09 20:42:47 Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal