| From: | Tatsuro Yamada <tatsuro(dot)yamada(dot)tf(at)nttcom(dot)co(dot)jp> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
| Cc: | legrand legrand <legrand_legrand(at)hotmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Is it useful to record whether plans are generic or custom? |
| Date: | 2020-11-30 06:24:23 |
| Message-ID: | c0c274c6-67c7-deae-ec0d-529f4c7a3675@nttcom.co.jp_1 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Torikoshi-san,
> In this patch, exposing new columns is mandatory, but I think
> it's better to make it optional by adding a GUC something
> like 'pgss.track_general_custom_plans.
>
> I also feel it makes the number of columns too many.
> Just adding the total time may be sufficient.
I think this feature is useful for DBA. So I hope that it gets
committed to PG14. IMHO, many columns are Okay because DBA can
select specific columns by their query.
Therefore, it would be better to go with the current design.
I did the regression test using your patch on 7e5e1bba03, and
it failed unfortunately. See below:
=======================================================
122 of 201 tests failed, 1 of these failures ignored.
=======================================================
...
2020-11-30 09:45:18.160 JST [12977] LOG: database system was not
properly shut down; automatic recovery in progress
Regards,
Tatsuro Yamada
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2020-11-30 06:45:15 | Re: Disable WAL logging to speed up data loading |
| Previous Message | Krunal Bauskar | 2020-11-30 06:19:25 | Re: Improving spin-lock implementation on ARM. |