Re: Inconsistent use of relpages = -1

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Inconsistent use of relpages = -1
Date: 2024-10-23 17:05:00
Message-ID: c078ff8ff48750452ac21455148500030ff9c8e8.camel@j-davis.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 2024-10-23 at 04:47 +0200, Laurenz Albe wrote:
> On Tue, 2024-10-22 at 10:41 -0700, Jeff Davis wrote:
> > I attached a patch that creates partitioned tables with relpages=-
> > 1,
> > and updates the docs.
>
> Does this need any changes for pg_upgrade?

pg_upgrade would go through the same DDL path, so I expect it would be
set to -1 in the upgraded cluster anyway. Are you seeing something
different?

In any case, the change is just meant to improve consistency and
documentation. I didn't intend to create a hard guarantee that it would
always be -1, so perhaps I should make the documentation more vague
with "may be" instead of "is"?

It bothers me somewhat that views still have relpages=0, because they
also don't have storage. Thoughts?

Regards,
Jeff Davis

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-10-23 17:20:27 Re: Inconsistent use of relpages = -1
Previous Message Heikki Linnakangas 2024-10-23 17:00:00 Re: Refine comments on usage WL_POSTMASTER_DEATH vs WL_EXIT_ON_PM_DEATH