Re: Minor lmgr code cleanup

On Sun, 07 Sep 2003 10:19:07 -0400, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
wrote:
>> +#define BITS_OFF(i) ~(1 << (i))
>
>I'd put another pair of parens around that. Also, it might be worth
>moving into a header file. There is at least one place in proc.c that
>manipulates lock masks using explicit shifts, because BITS_ON/BITS_OFF
>weren't visible outside lock.c.

Done. Small patch attached, should be applied after the large patch.
Big fat all-in-one patch available on request.

>BTW, did you check that the code still compiles with LOCK_DEBUG enabled?

No, I didn't and it didn't. :-( Corrected.

>How about contrib/userlock?

Unaffected by my changes, still works AFAICT.

Servus
Manfred