| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Jacob Champion <pchampion(at)vmware(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Ashwin Agrawal <aagrawal(at)pivotal(dot)io>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: alter table set TABLE ACCESS METHOD |
| Date: | 2021-07-28 20:05:10 |
| Message-ID: | bfad9843733672c468783532fd440731aceb1f8f.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 2021-07-28 at 14:02 +0900, Michael Paquier wrote:
> Arg, sorry about that! I was unclear what the situation of the patch
> was.
No problem, race condition ;-)
> Right. Isn't that an older issue though? A rewrite involved after a
> change of relpersistence does not call the hook either. It looks to
> me that this should be after finish_heap_swap() to match with
> ATExecSetTableSpace() in ATRewriteTables(). The only known user of
> object_access_hook in the core code is sepgsql, so this would
> involve a change of behavior. And I don't recall any backpatching
> that added a post-alter hook.
Sounds like it should be a different patch. Thank you.
> > Also, I agree with Justin that it should fail when there are
> > multiple
> > SET ACCESS METHOD subcommands consistently, regardless of whether
> > one
> > is a no-op, and it should probably throw a syntax error to match
> > SET
> > TABLESPACE.
>
> Hmm. Okay.
>
> > Minor nit: in tab-complete.c, why does it say "<smt>"? Is that just
> > a
> > typo or is there a reason it's different from everything else,
> > which
> > uses "<sth>"? And what does "sth" mean anyway?
>
> "Something". That should be "<sth>" to be consistent with the area.
These two issues are pretty minor.
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2021-07-28 20:10:53 | Re: [PATCH] test/ssl: rework the sslfiles Makefile target |
| Previous Message | Andres Freund | 2021-07-28 19:55:52 | Re: Out-of-memory error reports in libpq |