From: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> |
---|---|
To: | <fabriziomello(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, Rahila Syed <rahila(dot)syed(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, "[pgdg] Robert Haas" <robertmhaas(at)gmail(dot)com> |
Subject: | Re: [UNVERIFIED SENDER] Re: Minimal logical decoding on standbys |
Date: | 2021-01-26 09:31:33 |
Message-ID: | be72abfa-e62e-eb81-4e70-1b57fe6dc9e2@amazon.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 1/25/21 8:34 PM, Fabrízio de Royes Mello wrote:
>
> On Mon, Jan 18, 2021 at 8:48 AM Drouvot, Bertrand <bdrouvot(at)amazon(dot)com
> <mailto:bdrouvot(at)amazon(dot)com>> wrote:
> >
> > 3 and 4 were failing because the
> ResolveRecoveryConflictWithLogicalSlots() call was missing in
> ResolveRecoveryConflictWithSnapshot(): the new version attached adds it.
> >
> > The new version attached also provides a few changes to make it
> compiling on the current master (it was not the case anymore).
> >
> > I also had to change 023_standby_logical_decoding_conflicts.pl
> <http://023_standby_logical_decoding_conflicts.pl> (had to call
> $node_standby->create_logical_slot_on_standby($node_master,
> 'otherslot', 'postgres'); at the very beginning of the "DROP DATABASE
> should drops it's slots, including active slots" section)
> >
>
> Awesome and thanks a lot.
>
> Seems your patch series is broken... can you please `git format-patch`
> and send again?
Thanks for pointing out!
Enclosed a new series created with "format-patch" and that can be
applied with "git am":
$ git am v8-000*.patch
Applying: Allow logical decoding on standby.
Applying: Add info in WAL records in preparation for logical slot
conflict handling.
Applying: Handle logical slot conflicts on standby.
Applying: New TAP test for logical decoding on standby.
Applying: Doc changes describing details about logical decoding.
Bertrand
Attachment | Content-Type | Size |
---|---|---|
v8-0005-Doc-changes-describing-details-about-logical-deco.patch | text/plain | 1.7 KB |
v8-0004-New-TAP-test-for-logical-decoding-on-standby.patch | text/plain | 20.5 KB |
v8-0003-Handle-logical-slot-conflicts-on-standby.patch | text/plain | 25.3 KB |
v8-0002-Add-info-in-WAL-records-in-preparation-for-logica.patch | text/plain | 18.4 KB |
v8-0001-Allow-logical-decoding-on-standby.patch | text/plain | 9.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2021-01-26 09:38:43 | Re: Add SQL function for SHA1 |
Previous Message | Jaime Casanova | 2021-01-26 09:19:19 | Re: FETCH FIRST clause PERCENT option |