From: | Erik Rijkers <er(at)xs4all(dot)nl> |
---|---|
To: | Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, peter(dot)eisentraut(at)2ndquadrant(dot)com |
Subject: | bug/oversight in TestLib.pm and PostgresNode.pm |
Date: | 2017-03-22 15:51:06 |
Message-ID: | be69b71889566e5a69ba4404858be86e@xs4all.nl |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I am trying to re-create pgbench-over-logical-replication as a TAP-test.
(the wisdom of that might be doubted, and I appreciate comments on it
too, but it's really another subject).
While trying to test pgbench's stderr (looking for 'creating tables' in
output of the initialisation step) I ran into these two bugs (or
perhaps better 'oversights').
But especially the omission of command_fails_like() in PostgresNode.pm
feels like an bug.
In the end it was necessary to change TestLib.pm's command_like()
because command_fails_like() also checks for a non-zero return value
(which seems to make sense, but in this case not possible: pgbench
returns 0 on init with output on stderr).
make check-world passes without error
Thanks,
Erik Rijkers
Attachment | Content-Type | Size |
---|---|---|
0001-testlib-like-stderr.diff | text/x-diff | 792 bytes |
PostgresNode.pm.diff | text/x-diff | 566 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2017-03-22 15:59:32 | Re: [COMMITTERS] pgsql: Sync pg_dump and pg_dumpall output |
Previous Message | Andres Freund | 2017-03-22 15:49:41 | Re: Logical decoding on standby |