| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | meson missing test dependencies |
| Date: | 2024-12-02 10:10:56 |
| Message-ID: | bdba588f-69a9-4f3e-9b95-62d07210a32e@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I have noticed that under meson many tests don't have dependencies on
the build artifacts that they are testing. As an example among many, if
you make a source code change in contrib/cube/cube.c (see patch 0001 for
a demo) and then run
make -C contrib/cube check
the test run will reflect the changed code, because the "check" targets
typically depend on the "all" targets. But if you do this under meson with
meson test -C build --suite setup --suite cube
the code will not be rebuilt first, and the test run will not reflect
the changed code.
This seems straightforward to fix, see patch 0002. The meson test setup
has support for this, but it seems not widely used.
Patch 0003 is another example, this time for a TAP-style test.
Is there any reason this was not done yet?
| Attachment | Content-Type | Size |
|---|---|---|
| v0-0001-XXX-source-code-modification-for-test-demonstrati.patch | text/plain | 814 bytes |
| v0-0002-Add-test-dependency.patch | text/plain | 632 bytes |
| v0-0003-Add-test-dependency-for-TAP-module.patch | text/plain | 785 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2024-12-02 10:24:31 | Re: Make tuple deformation faster |
| Previous Message | Jim Jones | 2024-12-02 10:08:55 | Re: Truncate logs by max_log_size |