Re: [PATCH] Print error when libpq-refs-stamp fails

From: Anton Voloshin <a(dot)voloshin(at)postgrespro(dot)ru>
To: Rachel Heaton <rachelmheaton(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: pchampion(at)vmware(dot)com
Subject: Re: [PATCH] Print error when libpq-refs-stamp fails
Date: 2021-10-04 16:40:02
Message-ID: bd2c8409-d6b3-5de9-ba0f-40c1381f630f@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

On 28/09/2021 05:55, Rachel Heaton wrote:
> Hello,
>
> While developing I got this error and it was difficult to figure out
> what was going on.
>
> Thanks to Jacob, I was able to learn the context of the failure, so we
> created this small patch.

- ! nm -A -u $< 2>/dev/null | grep -v __cxa_atexit | grep exit
+ @if nm -a -u $< 2>/dev/null | grep -v __cxa_atexit | grep exit; then \
+ echo 'libpq must not be linked against any library calling exit';
exit 1; \
+ fi

Could you please confirm that the change from -A to -a in nm arguments
in this patch is intentional?

--
Anton Voloshin
Postgres Professional, The Russian Postgres Company
https://postgrespro.ru

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Shruthi Gowda 2021-10-04 16:44:21 Re: preserving db/ts/relfilenode OIDs across pg_upgrade (was Re: storing an explicit nonce)
Previous Message Jacob Champion 2021-10-04 16:14:37 Re: Support for NSS as a libpq TLS backend