Re: Failed to request an autovacuum work-item in silence

From: Ildar Musin <i(dot)musin(at)postgrespro(dot)ru>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Failed to request an autovacuum work-item in silence
Date: 2018-03-12 09:26:15
Message-ID: bd1995f9-1057-8e7e-5011-c1f1298e8867@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

autovac_get_workitem_name() declaration seems redundant and should be
removed. The same thing with including "utils/lsyscache.h" in brin.c.

The 'requested' variable in brininsert() I would again rename to
something like 'success' because a work item is requested anyway but
what matters is whether the request was satisfied/successful.

Except for those two points everything is fine and works as expected.

--
Ildar Musin
i(dot)musin(at)postgrespro(dot)ru

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Shinoda, Noriyoshi 2018-03-12 10:12:35 [HACKERS] Commitfest 2018-9 duplicate patch deletion request.
Previous Message Michail Nikolaev 2018-03-12 09:01:29 Re: [WIP PATCH] Index scan offset optimisation using visibility map