| From: | Tomas Vondra <tomas(at)vondra(dot)me> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, Andreas Karlsson <andreas(at)proxel(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: WIP: parallel GiST index builds |
| Date: | 2024-10-08 13:05:38 |
| Message-ID: | bcbc09a0-ac20-463f-a9fc-e1465569c065@vondra.me |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/8/24 04:05, Michael Paquier wrote:
> On Tue, Jul 30, 2024 at 11:05:56AM +0200, Tomas Vondra wrote:
>> I tried implementing this, see the attached 0002 patch that replaces the
>> fake LSN with an atomic counter in shared memory. It seems to work (more
>> testing needed), but I can't say I'm very happy with the code :-(
>
> While scanning quickly the code, please be careful about the query ID
> that should be passed down to _gist_parallel_build_main()..
Here's an updated patch adding the queryid.
regards
--
Tomas Vondra
| Attachment | Content-Type | Size |
|---|---|---|
| v20241008-0001-WIP-parallel-GiST-build.patch | text/x-patch | 36.9 KB |
| v20241008-0002-use-GetFakeLSNForUnloggedRel.patch | text/x-patch | 4.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2024-10-08 13:41:51 | Re: [PATCH] Add get_bytes() and set_bytes() functions |
| Previous Message | Ashutosh Bapat | 2024-10-08 13:01:47 | Re: Inconsistent RestrictInfo serial numbers |