Re: recovery_target_action=pause with confusing hint

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: "movead(dot)li(at)highgo(dot)ca" <movead(dot)li(at)highgo(dot)ca>, Sergei Kornilov <sk(at)zsrv(dot)org>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: recovery_target_action=pause with confusing hint
Date: 2020-04-08 06:59:59
Message-ID: bc5bcd80-5394-b123-e6f6-1dd8636b3075@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020/04/02 10:41, movead(dot)li(at)highgo(dot)ca wrote:
>
> >So I'd like to propose the attached patch. The patch changes the message
>>logged when a promotion is requested, based on whether the recovery is
>>in paused state or not.
> It is a compromise,

Ok, so barring any objection, I will commit the patch.

> we should notice it in document I think.

There is the following explation about the relationship the recovery
pause and the promotion, in the document. You may want to add more
descriptions into the docs?

------------------------------
If a promotion is triggered while recovery is paused, the paused
state ends and a promotion continues.
------------------------------

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message wenjing 2020-04-08 07:00:20 Re: [bug] Wrong bool value parameter
Previous Message David Rowley 2020-04-08 06:35:24 Re: Use compiler intrinsics for bit ops in hash