Re: pgsql: Move cancel key generation to after forking the backend

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Move cancel key generation to after forking the backend
Date: 2024-07-29 13:25:03
Message-ID: bc1e2356-a44d-47a7-a280-c8cb6c625a6a@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 29/07/2024 16:23, Daniel Gustafsson wrote:
>> On 29 Jul 2024, at 15:18, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> wrote:
>>
>> Move cancel key generation to after forking the backend
>
> longfin seems a tad sad about this one:
>
> procsignal.c:87:3: error: redefinition of typedef 'ProcSignalHeader' is a C11 feature [-Werror,-Wtypedef-redefinition]
> } ProcSignalHeader;
> ^
> ../../../../src/include/storage/procsignal.h:77:33: note: previous definition is here
> typedef struct ProcSignalHeader ProcSignalHeader;
> ^
> 1 error generated.
> make[4]: *** [procsignal.o] Error 1

Yep, thanks, just noticed and fixed it myself. I should add that to the
list of compiler options I use...

--
Heikki Linnakangas
Neon (https://neon.tech)

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2024-07-29 14:30:01 Re: pgsql: Move cancel key generation to after forking the backend
Previous Message Heikki Linnakangas 2024-07-29 13:23:47 pgsql: Fix compiler warning/error about typedef redefinitions