| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl. |
| Date: | 2021-10-21 20:55:10 |
| Message-ID: | bbf3f575-87ba-2f31-233b-677a84e53f82@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 10/20/21 5:48 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> OK, it turns out that it's better to put the addition at the end of the
>> PATH, otherise initdb complains that it can't find postgres in the same
>> directory.
> That seems horribly unsafe, or at least prone to pulling in the
> program from some other versuion of Postgres. How about ordering
> the path like
>
> PATH="$(abs_top_builddir)/tmp_install$(bindir):$(CURDIR):$$PATH"
>
>
fair point. See attached. Tested on MSVC and Linux
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| libpq_pipeline_fix5.patch | text/x-patch | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-10-21 21:09:17 | pgsql: Doc: clarify a critical and undocumented aspect of simplehash.h. |
| Previous Message | Daniel Gustafsson | 2021-10-21 08:41:44 | pgsql: Fix SSL tests on 32-bit Perl |