Re: Bug with pg_basebackup and 'shared' tablespace

From: Martín Marqués <martin(dot)marques(at)2ndquadrant(dot)com>
To: Pierre Ducroquet <p(dot)psql(at)pinaraf(dot)info>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Subject: Re: Bug with pg_basebackup and 'shared' tablespace
Date: 2017-09-26 15:13:25
Message-ID: bb614397-bb0c-df8c-6fce-3bc1e11f0303@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

El 13/09/17 a las 14:17, Pierre Ducroquet escribió:
> + bool firstfile = 1;

You are still assigning 1 to a bool (which is not incorrect) instead of
true or false as Michael mentioned before.

P.D.: I didn't go though all the thread and patch in depth so will not
comment further.

--
Martín Marqués http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bossart, Nathan 2017-09-26 15:53:09 Re: Enhancements to passwordcheck
Previous Message Jesper Pedersen 2017-09-26 14:57:15 Re: path toward faster partition pruning