Re: Support LIKE with nondeterministic collations

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Verite <daniel(at)manitou-mail(dot)org>, Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com>
Subject: Re: Support LIKE with nondeterministic collations
Date: 2024-11-27 08:01:26
Message-ID: bb5c479c-abc8-483f-9bfb-18894dc23a90@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 20.11.24 08:29, jian he wrote:
> in match_pattern_prefix maybe change
> if (expr_coll && !get_collation_isdeterministic(expr_coll))
> return NIL;
> to
> if (OidIsValid(expr_coll) && !get_collation_isdeterministic(expr_coll))
> return NIL;

I left it like it was, because this was existing code that I'm just
moving around.

> other than that, I didn't find any issue.

I have committed it, thanks.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2024-11-27 08:45:53 Re: An inefficient query caused by unnecessary PlaceHolderVar
Previous Message Sutou Kouhei 2024-11-27 07:53:44 Re: Make COPY format extendable: Extract COPY TO format implementations