Re: Proposal: Remove regress-python3-mangle.mk

From: Yury Zhuravlev <u(dot)zhuravlev(at)postgrespro(dot)ru>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposal: Remove regress-python3-mangle.mk
Date: 2016-04-20 08:43:53
Message-ID: bb11d177-a606-4361-a76b-1674ffb9c5b0@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Noah Misch wrote:
> Considering we have 2756 lines of Python test SQL and just thirteen lines of
> sed to mangle them, the current method is scaling nicely.
What pitfalls hides this approach? Convert python2 code to python3 it is
really bad practice.

>I may not understand that second sentence. We have multiple buildfarm members
>verifying the python2 case and multiple members verifying the python3 case.

I wrote about special python3 features what not testing today. We testing
Python3 as subset of Python2.

>The PL/Python implementation does not view them as different languages;
But it is really different languages.

If we do not want to have two different code base, then it is necessary to
use than this: https://pythonhosted.org/six/

The license allows us to copy this code into postgres.
Or use standart Python tool 2to3:
https://docs.python.org/2/library/2to3.html

Thanks.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2016-04-20 10:28:40 Re: Declarative partitioning
Previous Message Kyotaro HORIGUCHI 2016-04-20 08:18:30 Re: FATAL: could not send end-of-streaming message to primary: no COPY in progress