| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Andreas Karlsson <andreas(at)proxel(dot)se>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Convert sepgsql tests to TAP |
| Date: | 2024-07-24 16:33:53 |
| Message-ID: | bab85286-ea70-4e04-8ce0-a9bd5baf1fd2@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 24.07.24 16:31, Andreas Karlsson wrote:
> I took a quick look at the patch and I like that we standardize things a
> bit. But one thing I am not a fan of are all the use of sed and awk in
> the Perl script. I would prefer if that logic happened all in Perl,
> especially since we have some of it in Perl (e.g. chomp). Also I wonder
> if we should not use IPC::Run to do the tests since we already depend on
> it for the other TAP tests.
In principle yes, but here I tried not rewriting the tests too much but
just port them to a newer environment. I think the adjustments you
describe could be done as a second step.
(I don't really have any expertise in sepgsql or selinux, I'm just doing
this to reduce the dependency on makefiles for testing. So I'm trying
to use as light a touch as possible.)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-07-24 16:33:55 | Re: pg_upgrade and logical replication |
| Previous Message | Peter Eisentraut | 2024-07-24 16:31:28 | Re: Convert sepgsql tests to TAP |