From: | "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Pg Docs <pgsql-docs(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Responsive images in pgweb docs |
Date: | 2019-04-04 16:23:56 |
Message-ID: | ba31e0e1-4c9b-b309-70e8-8e7ac14fc87e@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs |
On 4/4/19 7:17 AM, Peter Eisentraut wrote:
> Here is a patch to improve this a bit. It turns back on making the SVG
> images in the HTML output scale with the page size. I also added some
> CSS stuff to make the width 75% on large screens for a more pleasing look.
>
> This fixes it for the gin image. The pagelayout image still doesn't
> scale, presumably for the reasons you identified inside the SVG code.
Tested against the local patch I have for pgweb for importing the docs
with appropriate classes. The GIN SVG does indeed scale properly, thanks!
As you mention, pagelayout still does not properly scale as it needs the
fix to scale.
Given you kept the gin.svg as is and that has some of the widths on it,
I'd propose we just add the viewbox on pagelayout.svg, i.e.
viewBox="0.00 0.00 610.00 210.00"
Fix attached. I tested this in both the HTML build and with the import
into pgweb with new patch, and it scaled correctly.
Thanks,
Jonathan
Attachment | Content-Type | Size |
---|---|---|
0001-Make-pagelayout.svg-scalable-based-viewport.patch | text/plain | 1.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | PG Doc comments form | 2019-04-04 17:20:06 | Building Source from windows clarification |
Previous Message | PG Doc comments form | 2019-04-04 14:54:29 | REFRESH MATERIALIZED VIEW CONCURRENTLY interaction with ORDER BY |